Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756430AbdDEX5z (ORCPT ); Wed, 5 Apr 2017 19:57:55 -0400 Received: from smtprelay0101.hostedemail.com ([216.40.44.101]:48053 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756407AbdDEX5p (ORCPT ); Wed, 5 Apr 2017 19:57:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:978:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3874:4321:5007:7514:7903:8957:10004:10400:10848:11232:11657:11658:11914:12043:12555:12740:12760:12895:13069:13138:13141:13230:13231:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:30054:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: smell22_6004eb8f20201 X-Filterd-Recvd-Size: 2045 Message-ID: <1491436658.27353.85.camel@perches.com> Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }. From: Joe Perches To: Valerio Genovese , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 05 Apr 2017 16:57:38 -0700 In-Reply-To: <1491420188-9482-1-git-send-email-valerio.click@gmail.com> References: <1491420188-9482-1-git-send-email-valerio.click@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 27 On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote: > This was reported by checkpatch.pl: > ERROR: space required after that close brace '}' > > Signed-off-by: Valerio Genovese > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h > index 2c398ca..5218f27 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h > @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{ > struct { > u16 FragNum:4; > u16 SeqNum:12; > - }field; > + } field; > }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL; What about the one on the next line? $ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}' drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'