Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934079AbdDFAiB (ORCPT ); Wed, 5 Apr 2017 20:38:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:35430 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbdDFAhx (ORCPT ); Wed, 5 Apr 2017 20:37:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,281,1488873600"; d="scan'208";a="1115993659" Subject: Re: [PATCH 0/5] IB/qib: Fine-tuning for four function implementations To: SF Markus Elfring , linux-rdma@vger.kernel.org, Doug Ledford , Hal Rosenstock , Mike Marciniszyn , Sean Hefty References: Cc: LKML , kernel-janitors@vger.kernel.org From: Dennis Dalessandro Message-ID: <300e66f1-7a27-8e6f-7ee0-f4998e22b78f@intel.com> Date: Wed, 5 Apr 2017 20:37:50 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 29 On 04/05/2017 09:50 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 5 Apr 2017 15:34:32 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Use kcalloc() in qib_init_iba7322_funcs() > Use kmalloc_array() in qib_init_7322_variables() > Use kcalloc() in qib_alloc_devdata() > Use kcalloc() in qib_init_pportdata() > Adjust two size determinations in qib_init_pportdata() > > drivers/infiniband/hw/qib/qib_iba7322.c | 20 ++++++++++++-------- > drivers/infiniband/hw/qib/qib_init.c | 27 +++++++++++++-------------- > 2 files changed, 25 insertions(+), 22 deletions(-) > Doug, I haven't reviewed these in detail yet but seems be along the lines of the patchset you decided not to take for cxgb [1]. I recommend not picking this up either. If something in here catches our eye Mike or I one will Ack it. [1] http://marc.info/?l=linux-rdma&m=149141638506039&w=2 -Denny