Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756340AbdDFAqh (ORCPT ); Wed, 5 Apr 2017 20:46:37 -0400 Received: from server.atrad.com.au ([150.101.241.2]:35346 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbdDFAqa (ORCPT ); Wed, 5 Apr 2017 20:46:30 -0400 Date: Thu, 6 Apr 2017 10:15:14 +0930 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Message-ID: <20170406004514.GC25480@marvin.atrad.com.au> References: <20170405064910.3162-1-kernel@kempniu.pl> <20170405153600.GC27833@fury> <20170405195534.GB892@kmp-mobile.hq.kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170405195534.GB892@kmp-mobile.hq.kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 32 Hi Michael On Wed, Apr 05, 2017 at 09:55:34PM +0200, Micha?? K??pie?? wrote: > > On Wed, Apr 05, 2017 at 08:48:59AM +0200, Micha?? K??pie?? wrote: > > > This series introduces further changes to the way LCD backlight is > > > handled by fujitsu-laptop. These changes include fixing a bug in code > > > responsible for generating brightness-related input events, cleaning up > > > handling of module parameters, reducing code duplication, removing > > > superfluous debug messages and other fixes. > > > > > > This series was tested on a Lifebook S7020 and a Lifebook E744. > > > > > > This series is based on the testing branch as it requires earlier patch > > > series I submitted in order to apply cleanly. > > > > > > Changes from v1: > > > > > > - Update debug message logged by set_lcd_level() to reflect code flow > > > changes introduced by patch 04/11. > > > > Queued to testing, thanks! > > Jonathan, I would still love to hear your opinion on this series. Take > your time, though, I do not see any reason to rush things. I will only > send the next series once you ack this one. Sure, no problem. As mentioned earlier, this week has been busy. I am hoping I might find the time to complete my review this evening. If not, it will be some time over the weekend. Regards jonathan