Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756608AbdDFBcl (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Apr 2017 21:32:41 -0400
Received: from cn.fujitsu.com ([59.151.112.132]:61975 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1756388AbdDFBcf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Apr 2017 21:32:35 -0400
X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; 
   d="scan'208";a="17406592"
Subject: Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with
 apic_virture_wire_mode_setup()
To: Thomas Gleixner <tglx@linutronix.de>
References: <1490799333-18242-1-git-send-email-douly.fnst@cn.fujitsu.com>
 <1490799333-18242-2-git-send-email-douly.fnst@cn.fujitsu.com>
 <alpine.DEB.2.20.1704051241150.2382@nanos>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>, <mingo@kernel.org>,
        <ebiederm@xmission.com>, <bhe@redhat.com>, <hpa@zytor.com>,
        <izumi.taku@jp.fujitsu.com>
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <56483804-e6ba-b956-a447-a73efdb83c90@cn.fujitsu.com>
Date: Thu, 6 Apr 2017 09:32:28 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1704051241150.2382@nanos>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.226.106]
X-yoursite-MailScanner-ID: 5BE414D14A41.A83AA
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 935
Lines: 46

Hi Thomas,

Thank you very much!

At 04/05/2017 06:43 PM, Thomas Gleixner wrote:
> On Wed, 29 Mar 2017, Dou Liyang wrote:
>
>> The init_bsp_APIC() setups the virtual wire mode through the local
>> APIC.
>>
>> The function name is unsuitable which might imply that the BSP's
>> APIC will be initialized here, actually, where it will be done is
>> almost at the end of start_kernel(). And the CONFIG X86_64 is also
>> imply the X86_LOCAL_APIC is y.
>
> Correct, but X86_32 can have X86_LOCAL_APIC=n. And by removing the ifdefs
> you break that.
>
>>  /*
>> - * An initial setup of the virtual wire mode.
>> + * Setup the through-local-APIC virtual wire mode.
>>   */
>> -void __init init_bsp_APIC(void)
>> +void apic_virture_wire_mode_setup(void)
>
> s/virture/virtual/ ?

Yes, It is.

>
> Why is this function not longer marked __init ?
>

Oops. The __init is necessary. I will modify it.

Thanks,
	Liyang.


> Thanks,
>
> 	tglx
>
>
>