Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756606AbdDFBi2 (ORCPT ); Wed, 5 Apr 2017 21:38:28 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:25512 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756280AbdDFBiV (ORCPT ); Wed, 5 Apr 2017 21:38:21 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="17406890" Subject: Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with apic_virture_wire_mode_setup() To: Thomas Gleixner References: <1490799333-18242-1-git-send-email-douly.fnst@cn.fujitsu.com> <1490799333-18242-2-git-send-email-douly.fnst@cn.fujitsu.com> CC: , , , , , , From: Dou Liyang Message-ID: <028d3f03-f25e-b538-3aaf-6e719a3d88d2@cn.fujitsu.com> Date: Thu, 6 Apr 2017 09:37:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: 03DC84D14A41.AC712 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 47 Hi Thomas, At 04/05/2017 06:50 PM, Thomas Gleixner wrote: > On Wed, 5 Apr 2017, Thomas Gleixner wrote: > >> On Wed, 29 Mar 2017, Dou Liyang wrote: >> >>> The init_bsp_APIC() setups the virtual wire mode through the local >>> APIC. >>> >>> The function name is unsuitable which might imply that the BSP's >>> APIC will be initialized here, actually, where it will be done is >>> almost at the end of start_kernel(). And the CONFIG X86_64 is also >>> imply the X86_LOCAL_APIC is y. >> >> Correct, but X86_32 can have X86_LOCAL_APIC=n. And by removing the ifdefs >> you break that. > > Oops. Sorry, the function is replaced by an empty stub for the APIC=n > case. So that's correct. > I forgot to clear it in the change log. I will add this comment to the change log. Thanks, Liyang >>> /* >>> - * An initial setup of the virtual wire mode. >>> + * Setup the through-local-APIC virtual wire mode. >>> */ >>> -void __init init_bsp_APIC(void) >>> +void apic_virture_wire_mode_setup(void) >> >> s/virture/virtual/ ? >> >> Why is this function not longer marked __init ? >> >> Thanks, >> >> tglx >> > > >