Subject: Re: [PATCH v3 1/9] drm: bridge: analogix: Detach panel when unbinding
 analogix dp
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>, briannorris@chromium.org,
        dianders@chromium.org, dri-devel@lists.freedesktop.org,
        tfiga@chromium.org, zain wang <wzz@rock-chips.com>, zyw@rock-chips.com,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <49db0245-4f6f-0de3-9a18-0d0a5aa0f37a@samsung.com>
Date: Thu, 06 Apr 2017 08:54:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.8.0
MIME-version: 1.0
In-reply-to: <1491380967-28570-2-git-send-email-jeffy.chen@rock-chips.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
CMS-TYPE: 201P
References: <1491380967-28570-1-git-send-email-jeffy.chen@rock-chips.com>
 <CGME20170405165839epcas1p36e69a04a402abdf79157052e5da6f3dc@epcas1p3.samsung.com>
 <1491380967-28570-2-git-send-email-jeffy.chen@rock-chips.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1023
Lines: 32

On 05.04.2017 10:29, Jeffy Chen wrote:
> The panel is attached when binding analogix dp.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
>
> Changes in v3: None
> Changes in v2:
> Fix some commit messages.
>
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index c26997a..28144a1 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1443,6 +1443,8 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
>  	if (dp->plat_data->panel) {
>  		if (drm_panel_unprepare(dp->plat_data->panel))
>  			DRM_ERROR("failed to turnoff the panel\n");
> +		if (drm_panel_detach(dp->plat_data->panel))
> +			DRM_ERROR("failed to detach the panel\n");
>  	}
>  
>  	pm_runtime_disable(dev);