Subject: Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when
 unbinding
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>, briannorris@chromium.org,
        dianders@chromium.org, dri-devel@lists.freedesktop.org,
        tfiga@chromium.org,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        zyw@rock-chips.com, Marek Szyprowski <m.szyprowski@samsung.com>
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <724682a8-e97b-660f-0867-306d068904ff@samsung.com>
Date: Thu, 06 Apr 2017 09:11:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.8.0
MIME-version: 1.0
In-reply-to: <1491380967-28570-3-git-send-email-jeffy.chen@rock-chips.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
CMS-TYPE: 201P
References: <1491380967-28570-1-git-send-email-jeffy.chen@rock-chips.com>
 <CGME20170405170151epcas5p1c9e4284f49c32426e4c9e7accd7cd6e3@epcas5p1.samsung.com>
 <1491380967-28570-3-git-send-email-jeffy.chen@rock-chips.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1178
Lines: 35

On 05.04.2017 10:29, Jeffy Chen wrote:
> The dp aux is registered when binding analogix dp.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Btw, if you are working already in this area you can check also to
analogix_dp bind and unbind routines they looks suspiciously asymmetric.
I guess component framework deals correctly with devm_* stuff but I see
for example clk_prepare_enable not paired with clk_unprepare*.

--
Regards
Andrzej
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 28144a1..7b75f82 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1447,6 +1447,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
>  			DRM_ERROR("failed to detach the panel\n");
>  	}
>  
> +	drm_dp_aux_unregister(&dp->aux);
>  	pm_runtime_disable(dev);
>  }
>  EXPORT_SYMBOL_GPL(analogix_dp_unbind);