Subject: Re: [PATCH v3 3/9] drm: bridge: analogix: Destroy connector when
 unbinding
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: Caesar Wang <wxt@rock-chips.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>, briannorris@chromium.org,
        dianders@chromium.org, dri-devel@lists.freedesktop.org,
        tfiga@chromium.org, zyw@rock-chips.com,
        Baoyou Xie <baoyou.xie@linaro.org>
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <c6e16910-2e4c-68aa-3aa5-62d588410ce5@samsung.com>
Date: Thu, 06 Apr 2017 09:19:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.8.0
MIME-version: 1.0
In-reply-to: <1491380967-28570-4-git-send-email-jeffy.chen@rock-chips.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
CMS-TYPE: 201P
References: <1491380967-28570-1-git-send-email-jeffy.chen@rock-chips.com>
 <CGME20170405165949epcas1p30c7d5d13cff9886a6faf0d529fcb1ab1@epcas1p3.samsung.com>
 <1491380967-28570-4-git-send-email-jeffy.chen@rock-chips.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1282
Lines: 40

On 05.04.2017 10:29, Jeffy Chen wrote:
> Normally we do this in drm_mode_config_cleanup. But analogix dp's
> connector is allocated in bind, and freed after unbind. So we need
> to destroy it in unbind to avoid further access.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

One comment below

> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 7b75f82..a96fd55 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1439,6 +1439,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
>  	struct analogix_dp_device *dp = dev_get_drvdata(dev);
>  
>  	analogix_dp_bridge_disable(dp->bridge);

Not related to the patch, but what about bridge,  above it is only
disabled, but not detached, encoder cleanup code should do it but it is
also missing.

Regards
Andrzej

> +	dp->connector.funcs->destroy(&dp->connector);
>  
>  	if (dp->plat_data->panel) {
>  		if (drm_panel_unprepare(dp->plat_data->panel))