Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbdDFI1B (ORCPT ); Thu, 6 Apr 2017 04:27:01 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:38160 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869AbdDFI05 (ORCPT ); Thu, 6 Apr 2017 04:26:57 -0400 MIME-Version: 1.0 In-Reply-To: <149142327748.5101.9712540392655343615.stgit@warthog.procyon.org.uk> References: <149142326734.5101.4596394505987813763.stgit@warthog.procyon.org.uk> <149142327748.5101.9712540392655343615.stgit@warthog.procyon.org.uk> From: Ard Biesheuvel Date: Thu, 6 Apr 2017 09:26:55 +0100 Message-ID: Subject: Re: [PATCH 01/24] efi: Add EFI_SECURE_BOOT bit To: David Howells Cc: "linux-kernel@vger.kernel.org" , One Thousand Gnomes , "linux-efi@vger.kernel.org" , Matthew Garrett , "gregkh@linuxfoundation.org" , linux-security-module , keyrings@vger.kernel.org, Josh Boyer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2219 Lines: 53 On 5 April 2017 at 21:14, David Howells wrote: > From: Josh Boyer > > UEFI machines can be booted in Secure Boot mode. Add a EFI_SECURE_BOOT bit > that can be passed to efi_enabled() to find out whether secure boot is > enabled. > > This will be used by the SysRq+x handler, registered by the x86 arch, to find > out whether secure boot mode is enabled so that it can be disabled. > > Signed-off-by: Josh Boyer > Signed-off-by: David Howells > cc: linux-efi@vger.kernel.org > --- > > arch/x86/kernel/setup.c | 1 + > include/linux/efi.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 4bf0c8926a1c..396285bddb93 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -1184,6 +1184,7 @@ void __init setup_arch(char **cmdline_p) > pr_info("Secure boot disabled\n"); > break; > case efi_secureboot_mode_enabled: > + set_bit(EFI_SECURE_BOOT, &efi.flags); > pr_info("Secure boot enabled\n"); > break; > default: Like I asked when this patch was sent round the last time: is there any reason for this not to live in generic code? > diff --git a/include/linux/efi.h b/include/linux/efi.h > index 94d34e0be24f..6049600e5475 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -1069,6 +1069,7 @@ extern int __init efi_setup_pcdp_console(char *); > #define EFI_DBG 8 /* Print additional debug info at runtime */ > #define EFI_NX_PE_DATA 9 /* Can runtime data regions be mapped non-executable? */ > #define EFI_MEM_ATTR 10 /* Did firmware publish an EFI_MEMORY_ATTRIBUTES table? */ > +#define EFI_SECURE_BOOT 11 /* Are we in Secure Boot mode? */ > > #ifdef CONFIG_EFI > /* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-efi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html