Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933676AbdDFIwi (ORCPT ); Thu, 6 Apr 2017 04:52:38 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:41627 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756345AbdDFIrJ (ORCPT ); Thu, 6 Apr 2017 04:47:09 -0400 From: Davidlohr Bueso To: mingo@kernel.org, peterz@infradead.org, akpm@linux-foundation.org Cc: jack@suse.cz, kirill.shutemov@linux.intel.com, ldufour@linux.vnet.ibm.com, mhocko@suse.com, mgorman@techsingularity.net, dave@stgolabs.net, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: [PATCH 3/6] locking/locktorture: Fix rwsem reader_delay Date: Thu, 6 Apr 2017 01:46:17 -0700 Message-Id: <20170406084620.22700-4-dave@stgolabs.net> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170406084620.22700-1-dave@stgolabs.net> References: <20170406084620.22700-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 24 We should account for nreader threads, not writers in this callback. Could even trigger a div by 0 if the user explicitly disables writers. Signed-off-by: Davidlohr Bueso --- kernel/locking/locktorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c index f24582d4dad3..0ef5510f8742 100644 --- a/kernel/locking/locktorture.c +++ b/kernel/locking/locktorture.c @@ -570,7 +570,7 @@ static void torture_rwsem_read_delay(struct torture_random_state *trsp) /* We want a long delay occasionally to force massive contention. */ if (!(torture_random(trsp) % - (cxt.nrealwriters_stress * 2000 * longdelay_ms))) + (cxt.nrealreaders_stress * 2000 * longdelay_ms))) mdelay(longdelay_ms * 2); else mdelay(longdelay_ms / 2); -- 2.12.0