Date: Fri, 30 May 2003 09:57:26 +0100
From: Dave Jones <davej@codemonkey.org.uk>
To: "David S. Miller" <davem@redhat.com>
Cc: chas@cmf.nrl.navy.mil, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] assorted he driver cleanup
Message-ID: <20030530085726.GA14723@suse.de>
Mail-Followup-To: Dave Jones <davej@codemonkey.org.uk>,
	"David S. Miller" <davem@redhat.com>, chas@cmf.nrl.navy.mil,
	linux-kernel@vger.kernel.org
References: <200305291609.h4TG9rx01188@relax.cmf.nrl.navy.mil> <20030529.200101.118622651.davem@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030529.200101.118622651.davem@redhat.com>
User-Agent: Mutt/1.5.4i
Sender: linux-kernel-owner@vger.kernel.org

On Thu, May 29, 2003 at 08:01:01PM -0700, David S. Miller wrote:

 > BTW, can you use more consistent changeset messages?  I always
 > at least allude to what is being changed, for example I changed
 > all of your messages to be of the form:
 > 
 > 	[ATM]: Blah blah blah in HE driver.
 > 
 > This tells the reader that:
 > 
 > 1) It's an ATM change.
 > 2) It's to the HE driver.
 > 3) The change made was "Blah blah blah" :-)

I'd also add...
4) keep the first line a brief oneliner summary, as it
gets truncated when Linus generates the shortlog.
 
A number of people (self included) have adopted this
impromptu 'standard' for bk comments. Maybe it should
get documented in Documentation/BK-usage/bk-kernel-howto.txt

		Dave


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/