Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933949AbdDFKFK (ORCPT ); Thu, 6 Apr 2017 06:05:10 -0400 Received: from mail.skyhub.de ([5.9.137.197]:33454 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753735AbdDFKFC (ORCPT ); Thu, 6 Apr 2017 06:05:02 -0400 Date: Thu, 6 Apr 2017 12:04:52 +0200 From: Borislav Petkov To: thor.thayer@linux.intel.com Cc: mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, thor.thayer@linux.intel.com.com Subject: Re: [PATCHv3] EDAC, altera: Fix peripheral warnings for Cyclone5 Message-ID: <20170406100451.ompmztbte7qi75x6@pd.tnic> References: <1491415262-5018-1-git-send-email-thor.thayer@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1491415262-5018-1-git-send-email-thor.thayer@linux.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 25 On Wed, Apr 05, 2017 at 01:01:02PM -0500, thor.thayer@linux.intel.com wrote: > From: Thor Thayer > > The peripherals EDACs only exist on the Arria10 SoCFPGA. The Cyclone5 > initialization has EDAC warnings when the peripherals aren't found > in the device tree. Fix by checking for Arria10 in the init functions. > > Signed-off-by: Thor Thayer > --- > v2 Change valid_model() return value from int to bool > Change valid_model() name to is_a10_model() for clarity. > Simplify expression - remove check for non-zero > v3 Use a simpler of_machine_is_compatible() expression. > Rename is_a10_model() to socfpga_is_a10(). > --- > drivers/edac/altera_edac.c | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.