Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752588AbdDFK6I (ORCPT ); Thu, 6 Apr 2017 06:58:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59312 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbdDFK6C (ORCPT ); Thu, 6 Apr 2017 06:58:02 -0400 Date: Thu, 6 Apr 2017 11:57:44 +0100 From: Mark Brown To: Richard Fitzgerald Cc: linus.walleij@linaro.org, gnurou@gmail.com, robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, lee.jones@linaro.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20170406105744.f5qpmmi2pjvc7n2z@sirena.org.uk> References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-8-git-send-email-rf@opensource.wolfsonmicro.com> <20170405134054.kz3j56vza4pqki75@sirena.org.uk> <1491400437.4096.5.camel@rf-debian.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5wfkgd3jlpzi3vd7" Content-Disposition: inline In-Reply-To: <1491400437.4096.5.camel@rf-debian.wolfsonmicro.main> X-Cookie: Poverty begins at home. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 07/16] regulator: madera-micsupp: Mic supply for Cirrus Logic Madera codecs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 37 --5wfkgd3jlpzi3vd7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 05, 2017 at 02:53:57PM +0100, Richard Fitzgerald wrote: > On Wed, 2017-04-05 at 14:40 +0100, Mark Brown wrote: > > Again, this appears to have only data and minor code style changes > > relative to the existing arizona driver - is there no opportunity for > > code sharing here? > I'll have a look at how it would work out. > My thought was that these two regulator drivers are so small it wasn't > worth creating an entanglement between arizona and madera for so little > code. It's a fairly small amount of code but it's an extremely high proportion of the code in the driver and doing something a bit unusual, not just boilerplate. --5wfkgd3jlpzi3vd7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljmHycACgkQJNaLcl1U h9DhaAf+MgOeQ1O1F7YETxiO6bPPXlueOsp5OuXiyDXFjzO/9ekNHkmsjxrSQvpT 8dcJVUx8lEHEvBB5zDs608/EobDSl+TKPT6Ud1O2ouczXHFxj627/6+bU8s9avNi V593V8cSNP9/9qzB60+iBOsLRvtICY2YPGmIuftVBI1bJFIDbxzMZvYApY1+q99Q KZiUuGM2VRlHPfDQhHODX1dlN8HNtVzMHmN1ldE1u2Catl3VAus9Cjo62g69tCkM 7KuHk3plxKPLdZD/lej8/OW1GB1qy/gS03Ui4eRgOJJz4jBGDzty4zQP1myiIXW2 MevGyBfDke4KCZNx3kQ7V6Y4AgTRBg== =/bkc -----END PGP SIGNATURE----- --5wfkgd3jlpzi3vd7--