Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933632AbdDFMGw (ORCPT ); Thu, 6 Apr 2017 08:06:52 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:32833 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533AbdDFMGo (ORCPT ); Thu, 6 Apr 2017 08:06:44 -0400 MIME-Version: 1.0 In-Reply-To: References: <1490864181-2192-1-git-send-email-richard@nod.at> <4c7a176b-6132-7936-a04f-d4def5e56320@nod.at> <646ae733-5037-3072-7151-b055a8fa1521@intel.com> From: Amir Goldstein Date: Thu, 6 Apr 2017 15:06:43 +0300 Message-ID: Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Richard Weinberger Cc: Adrian Hunter , linux-mtd@lists.infradead.org, linux-kernel , Artem Bityutskiy , "stable [v4.9]" , Ralph Sennhauser Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 26 On Thu, Mar 30, 2017 at 3:27 PM, Richard Weinberger wrote: > Am 30.03.2017 um 13:57 schrieb Adrian Hunter: >>> Reading deeper into the proved that I was wrong. >>> AFAIKT UBIFS' journal has currently no way to revive a deleted inode. >>> So, we have to think about a new solution. >> >> Deleting the orphan looks right. Just need to understand whether the >> recovery would do the right thing - actually it looks like O_TMPFILE might >> be OK and in other case we might be failing to remove nodes with sequence >> numbers greater than the deletion inode. > > Sadly it does not the right thing. > I'm currently investigating why and how to deal with it. > > I also managed to trigger that case. :( > Richard, Were you able to make any progress? still working on this? If this is too complicated to get in for this cycle, better send a patch to disable O_TMPFILE support for ubifs and fix the problem properly on followup merge cycle. Because right now ubifs O_TMPFILE support is broken and breaks overlayfs mount. Amir.