Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932371AbdDFMTA (ORCPT ); Thu, 6 Apr 2017 08:19:00 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:50465 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbdDFMSv (ORCPT ); Thu, 6 Apr 2017 08:18:51 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: a.hajda@samsung.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <7a8f421e43aec797c3653530bf2738d7> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <58E63215.8050800@rock-chips.com> Date: Thu, 06 Apr 2017 20:18:29 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Andrzej Hajda , linux-kernel@vger.kernel.org CC: Tomeu Vizoso , Daniel Vetter , briannorris@chromium.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, Laurent Pinchart , zyw@rock-chips.com, Marek Szyprowski Subject: Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding References: <1491380967-28570-1-git-send-email-jeffy.chen@rock-chips.com> <1491380967-28570-3-git-send-email-jeffy.chen@rock-chips.com> <724682a8-e97b-660f-0867-306d068904ff@samsung.com> In-Reply-To: <724682a8-e97b-660f-0867-306d068904ff@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 44 Hi Andrzej, On 04/06/2017 03:11 PM, Andrzej Hajda wrote: > On 05.04.2017 10:29, Jeffy Chen wrote: >> The dp aux is registered when binding analogix dp. >> >> Signed-off-by: Jeffy Chen > Reviewed-by: Andrzej Hajda > > Btw, if you are working already in this area you can check also to > analogix_dp bind and unbind routines they looks suspiciously asymmetric. > I guess component framework deals correctly with devm_* stuff but I see > for example clk_prepare_enable not paired with clk_unprepare*. ok, well do... > > -- > Regards > Andrzej >> --- >> >> Changes in v3: None >> Changes in v2: None >> >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> index 28144a1..7b75f82 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> @@ -1447,6 +1447,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master, >> DRM_ERROR("failed to detach the panel\n"); >> } >> >> + drm_dp_aux_unregister(&dp->aux); >> pm_runtime_disable(dev); >> } >> EXPORT_SYMBOL_GPL(analogix_dp_unbind); > > > > >