Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933179AbdDFMUt (ORCPT ); Thu, 6 Apr 2017 08:20:49 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:34127 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752851AbdDFMUk (ORCPT ); Thu, 6 Apr 2017 08:20:40 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: a.hajda@samsung.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <58E6328E.8090005@rock-chips.com> Date: Thu, 06 Apr 2017 20:20:30 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Andrzej Hajda , linux-kernel@vger.kernel.org CC: Caesar Wang , Tomeu Vizoso , Daniel Vetter , briannorris@chromium.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, zyw@rock-chips.com, Baoyou Xie Subject: Re: [PATCH v3 3/9] drm: bridge: analogix: Destroy connector when unbinding References: <1491380967-28570-1-git-send-email-jeffy.chen@rock-chips.com> <1491380967-28570-4-git-send-email-jeffy.chen@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1528 Lines: 50 Hi Andrzej, On 04/06/2017 03:19 PM, Andrzej Hajda wrote: > On 05.04.2017 10:29, Jeffy Chen wrote: >> Normally we do this in drm_mode_config_cleanup. But analogix dp's >> connector is allocated in bind, and freed after unbind. So we need >> to destroy it in unbind to avoid further access. >> >> Signed-off-by: Jeffy Chen > > Reviewed-by: Andrzej Hajda > > One comment below > >> --- >> >> Changes in v3: None >> Changes in v2: None >> >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> index 7b75f82..a96fd55 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> @@ -1439,6 +1439,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master, >> struct analogix_dp_device *dp = dev_get_drvdata(dev); >> >> analogix_dp_bridge_disable(dp->bridge); > > Not related to the patch, but what about bridge, above it is only > disabled, but not detached, encoder cleanup code should do it but it is > also missing. right, i should notice there's a drm_encoder_cleanup(dp->encoder) when failed to create bridge...thanx for pointing that out :) > > Regards > Andrzej > >> + dp->connector.funcs->destroy(&dp->connector); >> >> if (dp->plat_data->panel) { >> if (drm_panel_unprepare(dp->plat_data->panel)) > > > > >