Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934639AbdDFNGX (ORCPT ); Thu, 6 Apr 2017 09:06:23 -0400 Received: from ozlabs.org ([103.22.144.67]:48407 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934577AbdDFNGJ (ORCPT ); Thu, 6 Apr 2017 09:06:09 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 4c3b89effc281704d5395282c800c45e453235f6 In-Reply-To: <1491213104-24450-2-git-send-email-alistair@popple.id.au> To: Alistair Popple From: Michael Ellerman Cc: devicetree@vger.kernel.org, Alistair Popple , mhairgrove@nvidia.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, robh+dt@kernel.org, shailendras@nvidia.com Subject: Re: [v2, 2/3] powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev Message-Id: <3vzNHz2TyZz9sCX@ozlabs.org> Date: Thu, 6 Apr 2017 23:06:07 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 524 Lines: 14 On Mon, 2017-04-03 at 09:51:43 UTC, Alistair Popple wrote: > The pnv_pci_get_{gpu|npu}_dev functions are used to find associations > between nvlink PCIe devices and standard PCIe devices. However they > lacked basic sanity checking which results in NULL pointer > dereferencing if they are incorrect called can be harder to spot than > an explicit WARN_ON. > > Signed-off-by: Alistair Popple Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/4c3b89effc281704d5395282c800c4 cheers