Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935066AbdDFOOP (ORCPT ); Thu, 6 Apr 2017 10:14:15 -0400 Received: from foss.arm.com ([217.140.101.70]:43644 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934642AbdDFOOH (ORCPT ); Thu, 6 Apr 2017 10:14:07 -0400 Date: Thu, 6 Apr 2017 15:14:02 +0100 From: Juri Lelli To: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@arm.linux.org.uk, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, broonie@kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Message-ID: <20170406141402.GJ9429@e106622-lin> References: <20170327131825.32134-1-juri.lelli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327131825.32134-1-juri.lelli@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 42 Hi, On 27/03/17 14:18, Juri Lelli wrote: > Hi, > > arm and arm64 topology.c share a lot of code related to parsing of capacity > information. This is v3 of a solution [1] (based on Will's, Catalin's and > Mark's off-line suggestions) to move such common code in a single place: > drivers/base/arch_topology.c (by creating such file and conditionally compiling > it for arm and arm64 only). > > First 4 patches are actually fixes for the current code. > > Patch 5 is the actual refactoring. > > Patch 6 is a minor change suggested by Greg and can be squashed as needed. > > Patch 7 removes one of the extern symbols by changing a bit the now common > code. > > Patch 8 removes the remaining externs (as required by Russell during v1 review) > by creating a new header file include/linux/arch_topology.h and including that > from arm, arm64 and drivers. > > Last patch addresses Dietmar's comments to v1 and adds a 'atd_' prefix to > interfaces exported by drivers code and used by arch (and potentially others in > the future). > > Changes from v2: > > - rebase on top of 4.11-rc4 > - fix various problems pointed out by Greg, thanks for the review! > (see patch 5 for details) > Thanks Vincent for your comments. Everybody else, ping? Thanks, - Juri