Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755574AbdDFQ4V (ORCPT ); Thu, 6 Apr 2017 12:56:21 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:45012 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754781AbdDFQ4M (ORCPT ); Thu, 6 Apr 2017 12:56:12 -0400 Date: Thu, 6 Apr 2017 10:55:57 -0600 From: Jason Gunthorpe To: Paul Menzel Cc: "Maciej S. Szmigiero" , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, GNUtoo@no-log.org Subject: Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot Message-ID: <20170406165557.GD7657@obsidianresearch.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 36 On Thu, Apr 06, 2017 at 08:18:33AM +0200, Paul Menzel wrote: > Indeed, that improves the situation. I still need to pass `force=1` to the > module to get `/dev/tpm0`. No idea, why it’s not in included in Linux 4.9 > yet. Fair point.. Jarkko - could you forward that patch to -stable? > $ journalctl -k -o cat | grep tpm > tpm_tis tpm_tis: 1.2 TPM (device-id 0x3202, rev-id 5) > tpm tpm0: Issuing TPM_STARTUP > tpm tpm0: [Hardware Error]: Adjusting reported timeouts: A 10000->10000us B > 10000->10000us C 0->752000us D 0->752000us There could be more relavent kernel messages than this, try grep -i tpm ? > So do you have an idea, what “ACPI requirements” changed in the `tpm` module > since Linux 3.16 to be loaded automatically? We added direct ACPI binding to the driver in addition to PNP, so if you have an ACPI table it goes down that path and does some additional validation of what is in the TPM. The BIOS must provide a acpi_dev_resource_memory and a ACPI_SIG_TPM2 for the ACPI entry at a minimum. There are FW_BUG prints if those fail, so check your dmesg closely? http://lxr.free-electrons.com/source/drivers/char/tpm/tpm_tis.c#L250 If not, can you annotate in some printk's into tpm_tis_acpi_init and recompile/re-test? Jason