Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934026AbdDFRPV (ORCPT ); Thu, 6 Apr 2017 13:15:21 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:22513 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbdDFRPO (ORCPT ); Thu, 6 Apr 2017 13:15:14 -0400 To: Nicholas Mc Guire Cc: "James E.J. Bottomley" , Vikas Chaudhary , QLogic-Storage-Upstream@qlogic.com, "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qla4xxx: drop redundant init_completion From: "Martin K. Petersen" Organization: Oracle Corporation References: <1490179462-16559-1-git-send-email-der.herr@hofr.at> Date: Thu, 06 Apr 2017 13:15:04 -0400 In-Reply-To: <1490179462-16559-1-git-send-email-der.herr@hofr.at> (Nicholas Mc Guire's message of "Wed, 22 Mar 2017 11:44:22 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 340 Lines: 11 Nicholas Mc Guire writes: > The redundant init_completion() here seems to be a cut&past error as > struct scsi_qla_host only has 4 completion elements to initialize, > thus the duplicate init_completion(disable_acb_comp) is simply > removed. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering