Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756007AbdDFRqD (ORCPT <rfc822;w@1wt.eu>);
        Thu, 6 Apr 2017 13:46:03 -0400
Received: from imap0.codethink.co.uk ([185.43.218.159]:55564 "EHLO
        imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755961AbdDFRpq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 6 Apr 2017 13:45:46 -0400
Message-ID: <1491500739.10415.38.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 23/26] power: reset: at91-poweroff: timely shutdown
 LPDDR memories
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Sebastian Reichel <sre@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Date: Thu, 06 Apr 2017 18:45:39 +0100
In-Reply-To: <20170406083605.797902629@linuxfoundation.org>
References: <20170406083604.362636628@linuxfoundation.org>
         <20170406083605.797902629@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1381
Lines: 49

On Thu, 2017-04-06 at 10:38 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> commit 0b0408745e7ff24757cbfd571d69026c0ddb803c upstream.
> 
> LPDDR memories can only handle up to 400 uncontrolled power off. Ensure the
> proper power off sequence is used before shutting down the platform.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[...] 
> +static void at91_lpddr_poweroff(void)
> +{
> +	asm volatile(
> +		/* Align to cache lines */
> +		".balign 32\n\t"
> +
> +		/* Ensure AT91_SHDW_CR is in the TLB by reading it */
> +		"	ldr	r6, [%2, #" __stringify(AT91_SHDW_CR) "]\n\t"

This clobbers r6...

> +		/* Power down SDRAM0 */
> +		"	str	%1, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
> +		/* Shutdown CPU */
> +		"	str	%3, [%2, #" __stringify(AT91_SHDW_CR) "]\n\t"
> +
> +		"	b	.\n\t"
> +		:
> +		: "r" (mpddrc_base),
> +		  "r" cpu_to_le32(AT91_DDRSDRC_LPDDR2_PWOFF),
> +		  "r" (at91_shdwc_base),
> +		  "r" cpu_to_le32(AT91_SHDW_KEY | AT91_SHDW_SHDW)
> +		: "r0");
[...]

...but the clobber list has r0.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.