Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755486AbdDFSWH (ORCPT ); Thu, 6 Apr 2017 14:22:07 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:35041 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754797AbdDFSVv (ORCPT ); Thu, 6 Apr 2017 14:21:51 -0400 Date: Thu, 6 Apr 2017 21:21:47 +0300 From: "Kirill A. Shutemov" To: Borislav Petkov Cc: Wei Yang , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo() Message-ID: <20170406182147.mwifrukq7ylczi6i@node.shutemov.name> References: <20170314030801.13656-1-richard.weiyang@gmail.com> <20170314030801.13656-2-richard.weiyang@gmail.com> <20170406124459.dwn5zhpr2xqg3lqm@node.shutemov.name> <20170406145937.docce7sa5tuqyon4@pd.tnic> <20170406154216.a4um6ftjyia5wxya@node.shutemov.name> <20170406180113.hvcydzrjldodosfo@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170406180113.hvcydzrjldodosfo@pd.tnic> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 31 On Thu, Apr 06, 2017 at 08:01:13PM +0200, Borislav Petkov wrote: > On Thu, Apr 06, 2017 at 06:42:16PM +0300, Kirill A. Shutemov wrote: > > Config is attached. > > Thanks! > > > Looks like fake numa is the key. > > ... > > > NUMA: Warning: node ids are out of bound, from=0 to=1 distance=20 [ 0.000000] numa_register_memblks: numa_nodes_parsed: 0 > > numa_register_memblks: nid: 0 > > numa_register_memblks: nid: 1 > > numa_register_memblks: nid: 2 > > numa_register_memblks: nid: 3 > > Yeah, the fake numa thing calls emu_setup_memblk() and that doesn't > set numa_nodes_parsed to the number of fake numa nodes. And since with > that "cleanup" which opened more work than it saved (btw, this is the > last time I'm looking at crap like that) we got rid of the "enlarging" > of the node mask to the actual nodes count and *that* blows up with > numa_nodes_parsed having only node 0 in there. > > Long story short, something as trivial as this helps here: Yep. Works for me. Reported-and-tested-by: Kirill A. Shutemov -- Kirill A. Shutemov