Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755484AbdDFStA (ORCPT <rfc822;w@1wt.eu>);
        Thu, 6 Apr 2017 14:49:00 -0400
Received: from mail.skyhub.de ([5.9.137.197]:51740 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753522AbdDFSsu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 6 Apr 2017 14:48:50 -0400
Date: Thu, 6 Apr 2017 20:48:38 +0200
From: Borislav Petkov <bp@alien8.de>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, tj@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [Patch V2 2/2] x86/mm/numa: remove the
 numa_nodemask_from_meminfo()
Message-ID: <20170406184838.z4pa4j33z2rp4mrg@pd.tnic>
References: <20170314030801.13656-1-richard.weiyang@gmail.com>
 <20170314030801.13656-2-richard.weiyang@gmail.com>
 <20170406124459.dwn5zhpr2xqg3lqm@node.shutemov.name>
 <20170406145937.docce7sa5tuqyon4@pd.tnic>
 <20170406154216.a4um6ftjyia5wxya@node.shutemov.name>
 <20170406180113.hvcydzrjldodosfo@pd.tnic>
 <20170406182147.mwifrukq7ylczi6i@node.shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170406182147.mwifrukq7ylczi6i@node.shutemov.name>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1244
Lines: 43

On Thu, Apr 06, 2017 at 09:21:47PM +0300, Kirill A. Shutemov wrote:
> > Long story short, something as trivial as this helps here:
> 
> Yep. Works for me.
> 
> Reported-and-tested-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Thanks.

Now, I'd really like to have more test coverage and be sure this
"cleanup" doesn't break anything else so Wei, please grab tip/master,
apply the oneliner from two messages ago, take Kirill's qemu cmdline
and run all fake numa scenarios you can think of to make sure your
cleanup doesn't break anything else.

Qemu can emulate real numa too, for example you can boot with:

-smp 64 \
-numa node,nodeid=0,cpus=1-8 \
-numa node,nodeid=1,cpus=9-16 \
-numa node,nodeid=2,cpus=17-24 \
-numa node,nodeid=3,cpus=25-32 \
-numa node,nodeid=4,cpus=0 \
-numa node,nodeid=4,cpus=33-39 \
-numa node,nodeid=5,cpus=40-47 \
-numa node,nodeid=6,cpus=48-55 \
-numa node,nodeid=7,cpus=56-63

after configuring the kernel accordingly.

Then, test baremetal too.

numa_emulation() should give you an idea about possible options
numa=fake takes. Documentation/x86/x86_64/boot-options.txt has some
(all?) too.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.