Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbdDFUZI (ORCPT ); Thu, 6 Apr 2017 16:25:08 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37692 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbdDFUY7 (ORCPT ); Thu, 6 Apr 2017 16:24:59 -0400 Date: Thu, 06 Apr 2017 13:24:57 -0700 (PDT) Message-Id: <20170406.132457.208185850211874734.davem@davemloft.net> To: colin.king@canonical.com Cc: Yuval.Mintz@cavium.com, Ariel.Elior@cavium.com, everest-linux-l2@cavium.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qed: fix missing break in OOO_LB_TC case From: David Miller In-Reply-To: <20170405123544.18648-1-colin.king@canonical.com> References: <20170405123544.18648-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Apr 2017 12:43:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 510 Lines: 16 From: Colin King Date: Wed, 5 Apr 2017 13:35:44 +0100 > From: Colin Ian King > > There seems to be a missing break on the OOO_LB_TC case, pq_id > is being assigned and then re-assigned on the fall through default > case and that seems suspect. > > Detected by CoverityScan, CID#1424402 ("Missing break in switch") > > Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration") > > Signed-off-by: Colin Ian King Applied, thanks.