Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755463AbdDFUdc (ORCPT ); Thu, 6 Apr 2017 16:33:32 -0400 Received: from mout.web.de ([212.227.15.3]:58186 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbdDFUdW (ORCPT ); Thu, 6 Apr 2017 16:33:22 -0400 Subject: Re: IB/qib: Adjust two size determinations in qib_init_pportdata() To: Yuval Shaia Cc: linux-rdma@vger.kernel.org, Doug Ledford , Hal Rosenstock , Mike Marciniszyn , Sean Hefty , LKML , kernel-janitors@vger.kernel.org References: <20170405143242.GB5006@yuval-lap> <523b0864-e655-ed1f-8fe5-5995e0b0bde1@users.sourceforge.net> <20170405151525.GA5519@yuval-lap> <20170406194823.GA28301@yuval-lap> From: SF Markus Elfring Message-ID: <8991d27a-0b8d-70f5-81d2-c830c3dd6f78@users.sourceforge.net> Date: Thu, 6 Apr 2017 22:33:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170406194823.GA28301@yuval-lap> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:6uemoLGfEkh5wt5Iv1nSHQEVUfd9Rfw59/js6W6WyHL58WUh4p2 /PENez5iIqRJVUjJO/AGMereZ3dXXTcjEldQBNJv11QEkAh9LqlKqZtKbKXqqNoHW798jDf uSLNXJzLG518DkjRH0ueTr4PHNMPe42QwIna2LPahTyvPWd6g8XK5ugzAJVKGeQlBK0f2ut zRvFavAV9/YuW5nSqkv0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:k0HzcKKhDB0=:nyxaYk9Rc/ZUfK6HW3u78y oGBdb6NoZwUYer3ShDIjjaMJaJihwnnAupI+3BF6abC8xNeYsnAF1zJl98VTsihtUSImiSi4z xDZRFWiQHhG5xAW4bVYMseInfpu2hk/40bI4tRiwlMaWoyaC/kQPzngXq96GXLCKtAKJknVxt RTVQkIwsbpUBrUUMtRP8qVyvYu1JMhlqdDWZ/X4t5bEQFNAfK0aEqbPdxc7FaqwRHJ88VrlSH AyUkx1znvWA2aV1aO2PxrZry6AtzkDwDn31Zybi+PBtxjjhSMvFOZ9bMYdssJAUDQ0YKg29uv 0C2g5BT9BmT4zed4vxu5AZalKY9d/6vMMxlgiDYTTThRirCXn/5sbh0gu+jRIKKa8UHnOQYLS WYFwrvfxQBWtL8wAKIx/TBDc7IY8MrvQrLr7rgCuJ9DFQr26F0BiDC6vqpgeRU2JFFOE92pZz ryXPW+AHiTAyxogAYXcRAT74QCc4n1HNsk/p8DHGsqyaPLgEW73Wut0eC9RpgYn4/z8ypwV64 c1fvLMz2DZ84J/dY1in2avkUby9CVLzWZJrTAXtv4bmkJw8s1L0Vr3joS8AD8ONjt+qmza0uf Q8vknKv7cIdP1ihiGQr1RmstiXXhMaw9jfjP/c80rZlfh8oTjaSuHtfurcwHWahepWespF28P IcKOxurzT/ChrE1GU++fvBPjbXR27yNnDwnUv5J5+g68jWmIBkUkAjuVGX2gQh9bYkKhRq9r6 8jcpbgzTGsGauMQhckS9luKJpbN9VLcGLF/7iYx6B2KSUHU0z3SomN1gm3BiFf4iGTKPZvrHb PU2AJdD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 13 >> How do you think about to take another look at remaining update candidates >> at other source code places for this Linux module? > > You mean the other patches in this patch-set? Partly, yes. - Do you care for adjustments around numbered jump labels (and suggestions from the script "checkpatch.pl") for example? Will it be more important to check return values from all calls of a function like "kmalloc" in related source files? Regards, Markus