Date: Thu, 6 Apr 2017 14:21:42 -0700 (PDT)
From: Himanshu Madhani <himanshu.madhani@cavium.com>
To: Colin King <colin.king@canonical.com>
cc: qla2xxx-upstream@qlogic.com,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove some redundant pointer
 assignments
In-Reply-To: <20170406111957.17250-1-colin.king@canonical.com>
Message-ID: <alpine.OSX.2.21.1704061421001.25469@deathstar.local>
References: <20170406111957.17250-1-colin.king@canonical.com>
User-Agent: Alpine 2.21 (OSX 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2017 21:21:45.5549 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1839
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2198
Lines: 77


On Thu, 6 Apr 2017, 4:19am, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> There are several local or function parameter pointers that are
> being assigned NULL after a kfree where and these have no effect
> and hence can be removed.
> 
> Fixes various cppcheck warnings:
> 
> "Assignment of function parameter has no effect outside the
> function. Did you forget dereferencing it"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/scsi/qla2xxx/qla_os.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 83d61d2142e9..1c7957903283 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -423,7 +423,6 @@ static void qla2x00_free_req_que(struct qla_hw_data *ha, struct req_que *req)
>  		kfree(req->outstanding_cmds);
>  
>  	kfree(req);
> -	req = NULL;
>  }
>  
>  static void qla2x00_free_rsp_que(struct qla_hw_data *ha, struct rsp_que *rsp)
> @@ -439,7 +438,6 @@ static void qla2x00_free_rsp_que(struct qla_hw_data *ha, struct rsp_que *rsp)
>  		rsp->ring, rsp->dma);
>  	}
>  	kfree(rsp);
> -	rsp = NULL;
>  }
>  
>  static void qla2x00_free_queues(struct qla_hw_data *ha)
> @@ -653,7 +651,6 @@ qla2x00_sp_free_dma(void *ptr)
>  		ha->gbl_dsd_inuse -= ctx1->dsd_use_cnt;
>  		ha->gbl_dsd_avail += ctx1->dsd_use_cnt;
>  		mempool_free(ctx1, ha->ctx_mempool);
> -		ctx1 = NULL;
>  	}
>  
>  	CMD_SP(cmd) = NULL;
> @@ -3256,7 +3253,6 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
>  	}
>  	pci_release_selected_regions(ha->pdev, ha->bars);
>  	kfree(ha);
> -	ha = NULL;
>  
>  probe_out:
>  	pci_disable_device(pdev);
> @@ -3504,7 +3500,6 @@ qla2x00_remove_one(struct pci_dev *pdev)
>  
>  	pci_release_selected_regions(ha->pdev, ha->bars);
>  	kfree(ha);
> -	ha = NULL;
>  
>  	pci_disable_pcie_error_reporting(pdev);
>  
> @@ -3568,7 +3563,6 @@ void qla2x00_free_fcports(struct scsi_qla_host *vha)
>  		list_del(&fcport->list);
>  		qla2x00_clear_loop_id(fcport);
>  		kfree(fcport);
> -		fcport = NULL;
>  	}
>  }
>  
> 

Looks Good. 

Acked-By: Himanshu Madhani <himanshu.madhani@cavium.com>