Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754749AbdDFVZ6 (ORCPT ); Thu, 6 Apr 2017 17:25:58 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35345 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881AbdDFVZs (ORCPT ); Thu, 6 Apr 2017 17:25:48 -0400 Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }. To: Joe Perches , gregkh@linuxfoundation.org References: <1491420188-9482-1-git-send-email-valerio.click@gmail.com> <1491436658.27353.85.camel@perches.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Valerio G Message-ID: <4fe785d2-c7a8-2d5a-4a6d-1fbfe0e8bb89@gmail.com> Date: Thu, 6 Apr 2017 23:25:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1491436658.27353.85.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 36 Hi, Thanks for the feedback. I re-submitted the patch as v2. best Valerio Il 06/04/2017 01:57, Joe Perches ha scritto: > On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote: >> This was reported by checkpatch.pl: >> ERROR: space required after that close brace '}' >> >> Signed-off-by: Valerio Genovese >> --- >> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h >> index 2c398ca..5218f27 100644 >> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h >> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h >> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{ >> struct { >> u16 FragNum:4; >> u16 SeqNum:12; >> - }field; >> + } field; >> }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL; > > What about the one on the next line? > > $ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}' > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}' >