Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932856AbdDFXS7 (ORCPT ); Thu, 6 Apr 2017 19:18:59 -0400 Received: from mail-pg0-f49.google.com ([74.125.83.49]:32953 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932530AbdDFXSk (ORCPT ); Thu, 6 Apr 2017 19:18:40 -0400 From: Laura Abbott To: Daniel Vetter , Chris Wilson , Sean Paul Cc: Laura Abbott , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sumit Semwal Subject: [RFC PATCH 1/2] drm/vgem: Add a dummy platform device Date: Thu, 6 Apr 2017 16:18:32 -0700 Message-Id: <1491520713-14277-2-git-send-email-labbott@redhat.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491520713-14277-1-git-send-email-labbott@redhat.com> References: <1491520713-14277-1-git-send-email-labbott@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1700 Lines: 57 The vgem driver is currently registered independent of any actual device. Some usage of the dmabuf APIs require an actual device structure to do anything. Register a dummy platform device for use with dmabuf. Signed-off-by: Laura Abbott --- I realize the original driver had a note about 'drop platform support'. I strongly dislike platform devices but they are the easiest way to get a device structure for use with APIs like dmabuf. --- drivers/gpu/drm/vgem/vgem_drv.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index a1f42d1..b94feef 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -329,12 +329,19 @@ static struct drm_driver vgem_driver = { }; static struct drm_device *vgem_device; +static struct platform_device *vgem_pdev; static int __init vgem_init(void) { int ret; - vgem_device = drm_dev_alloc(&vgem_driver, NULL); + vgem_pdev = platform_device_register_simple("vgem", -1, NULL, 0); + if (IS_ERR(vgem_pdev)) + return PTR_ERR(vgem_pdev); + + dma_coerce_mask_and_coherent(&vgem_pdev->dev, DMA_BIT_MASK(64)); + + vgem_device = drm_dev_alloc(&vgem_driver, &vgem_pdev->dev); if (IS_ERR(vgem_device)) { ret = PTR_ERR(vgem_device); goto out; @@ -349,6 +356,8 @@ static int __init vgem_init(void) out_unref: drm_dev_unref(vgem_device); out: + platform_device_unregister(vgem_pdev); + return ret; } @@ -356,6 +365,7 @@ static void __exit vgem_exit(void) { drm_dev_unregister(vgem_device); drm_dev_unref(vgem_device); + platform_device_unregister(vgem_pdev); } module_init(vgem_init); -- 2.7.4