Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754573AbdDGHvV (ORCPT ); Fri, 7 Apr 2017 03:51:21 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:4165 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbdDGHvP (ORCPT ); Fri, 7 Apr 2017 03:51:15 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 07 Apr 2017 00:51:14 -0700 Subject: Re: [PATCH V3 3/4] pwm: tegra: Add DT binding details to configure pin in suspends/resume To: Laxman Dewangan , , References: <1491488461-24621-1-git-send-email-ldewangan@nvidia.com> <1491488461-24621-4-git-send-email-ldewangan@nvidia.com> <58E67152.1080400@nvidia.com> CC: , , , , From: Jon Hunter Message-ID: Date: Fri, 7 Apr 2017 08:49:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <58E67152.1080400@nvidia.com> X-Originating-IP: [10.21.132.162] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 38 On 06/04/17 17:48, Laxman Dewangan wrote: > > On Thursday 06 April 2017 08:56 PM, Jon Hunter wrote: >> On 06/04/17 15:21, Laxman Dewangan wrote: >>> In some of NVIDIA Tegra's platform, PWM controller is used to >>> control the PWM controlled regulators. PWM signal is connected to >>> the VID pin of the regulator where duty cycle of PWM signal decide >>> the voltage level of the regulator output. >>> >>> The tristate (high impedance of PWM pin form Tegra) also define >> s/form/from/ >> s/define/defines/ >> >>> one of the state of PWM regulator which needs to be configure in >>> suspend state of system. >> It maybe clearer to say that when the system enters suspend the >> regulator requires the pwm output to be tristated. > > Not necessarily that every PWM regulator interfaces needs it. It > depends on the devices. Yes I understand that. I am just saying the description could be a little clearer. > So I will say: > > When system enters suspend, in some of PWM regulator interface, it is > required to to set the PWM output to be tristated. Ok, but I think you should say why that is, because from the above sentence alone it is not clear. Maybe you should say that some PWM client/slave devices require the PWM output to be tristated. Jon -- nvpublic