Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755464AbdDGImz (ORCPT ); Fri, 7 Apr 2017 04:42:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:60957 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbdDGImk (ORCPT ); Fri, 7 Apr 2017 04:42:40 -0400 Date: Fri, 07 Apr 2017 10:42:37 +0200 Message-ID: From: Takashi Iwai To: "David Howells" Cc: , , , , "Jaroslav Kysela" , , Subject: Re: [PATCH 35/38] Annotate hardware config module parameters in sound/drivers/ In-Reply-To: <149141171975.29162.18186172352089656358.stgit@warthog.procyon.org.uk> References: <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141171975.29162.18186172352089656358.stgit@warthog.procyon.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1513 Lines: 37 On Wed, 05 Apr 2017 19:01:59 +0200, David Howells wrote: > > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > access by means of configuring driver modules in such a way as to cause a > device to access or modify the kernel image. > > To this end, annotate module_param* statements that refer to hardware > configuration and indicate for future reference what type of parameter they > specify. The parameter parser in the core sees this information and can > skip such parameters with an error message if the kernel is locked down. > The module initialisation then runs as normal, but just sees whatever the > default values for those parameters is. > > Note that we do still need to do the module initialisation because some > drivers have viable defaults set in case parameters aren't specified and > some drivers support automatic configuration (e.g. PNP or PCI) in addition > to manually coded parameters. > > This patch annotates drivers in sound/drivers/. > > Suggested-by: Alan Cox > Signed-off-by: David Howells > cc: Jaroslav Kysela > cc: Takashi Iwai > cc: alsa-devel@alsa-project.org The changes look fairly straightforward, so feel free to take my ack for sound/* stuff: Acked-by: Takashi Iwai thanks, Takashi