Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175AbdDGIxP (ORCPT ); Fri, 7 Apr 2017 04:53:15 -0400 Received: from foss.arm.com ([217.140.101.70]:52302 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755991AbdDGIw7 (ORCPT ); Fri, 7 Apr 2017 04:52:59 -0400 Subject: Re: [PATCH v4 0/3] Add Mediatek CIRQ interrupt controller To: Youlin Pei , Rob Herring , Matthias Brugger References: <1491552397-7893-1-git-send-email-youlin.pei@mediatek.com> Cc: Thomas Gleixner , Jason Cooper , Mark Rutland , Russell King , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, hongkun.cao@mediatek.com, yong.wu@mediatek.com, erin.lo@mediatek.com From: Marc Zyngier Organization: ARM Ltd Message-ID: <771954fe-c994-96be-76ab-ece75383d058@arm.com> Date: Fri, 7 Apr 2017 09:52:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491552397-7893-1-git-send-email-youlin.pei@mediatek.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 35 On 07/04/17 09:06, Youlin Pei wrote: > In Mediatek SOCs, the CIRQ is a low power interrupt controller designed to > works outside MCUSYS which comprises with Cortex-Ax cores,CCI and GIC. > > The CIRQ controller is integrated in between MCUSYS and interrupt sources > as the second level interrupt controller. The external interrupts which > outside MCUSYS will feed through CIRQ then bypass to GIC. > > In normal mode(where MCUSYS is active), CIRQ is disabled and interrupts > will directly issue to MCUSYS. When MCUSYS enters sleep mode, where GIC > is power downed. CIRQ will be enabled and monitor all edge trigger > interrupts(only edge trigger interrupts will be lost in this scenario). > When an edge interrupt is triggered, CIRQ will record the status and > generated a pulse signal to GIC when flush command is executed. > > With CIRQ, MCUSYS can be completely turned off to improve the system > power consumption without losing interrupts. > > change in v4: > 1. add some comment to explain CIRQ suspend callback. > 2. rebase on 4.11 Hi Youlin, I'm happy to take the first two patches through the irq tree. How do we deal with the third one? It seems to me that it'd be better routed via armsoc. Let me know what you and Matthias want to do. Thanks, M. -- Jazz is not dead. It just smells funny...