Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933093AbdDGLtT (ORCPT ); Fri, 7 Apr 2017 07:49:19 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:5927 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753654AbdDGLtK (ORCPT ); Fri, 7 Apr 2017 07:49:10 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 07 Apr 2017 04:49:09 -0700 Date: Fri, 7 Apr 2017 14:49:01 +0300 From: Peter De Schrijver To: Michael Turquette , Stephen Boyd , , CC: Alex Frid Subject: Re: [PATCH] clk: Add requested rate to clock summary output Message-ID: <20170407114901.GA30730@tbergstrom-lnx.Nvidia.com> References: <1490188803-13034-1-git-send-email-pdeschrijver@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1490188803-13034-1-git-send-email-pdeschrijver@nvidia.com> X-NVConfidentiality: public User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.21.24.170] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To UKMAIL101.nvidia.com (10.26.138.13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2478 Lines: 59 On Wed, Mar 22, 2017 at 03:20:03PM +0200, Peter De Schrijver wrote: > From: Alex Frid > > Added requested rate to clock summary output and to clock dump. This is > useful for clock tree debugging. Also expand the clock name field in the > clock tree debugfs output to provide room for deep multi-tier trees like > on Tegra. > Ping! Any comments on this? Peter. > Signed-off-by: Alex Frid > Signed-off-by: Peter De Schrijver > --- > drivers/clk/clk.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 0b815d1..3f6ae6d 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -2007,10 +2007,10 @@ static void clk_summary_show_one(struct seq_file *s, struct clk_core *c, > if (!c) > return; > > - seq_printf(s, "%*s%-*s %11d %12d %11lu %10lu %-3d\n", > + seq_printf(s, "%*s%-*s %11d %12d %11lu %11lu %10lu %-3d\n", > level * 3 + 1, "", > - 30 - level * 3, c->name, > - c->enable_count, c->prepare_count, clk_core_get_rate(c), > + 48 - level * 3, c->name, c->enable_count, > + c->prepare_count, clk_core_get_rate(c), c->req_rate, > clk_core_get_accuracy(c), clk_core_get_phase(c)); > } > > @@ -2033,8 +2033,8 @@ static int clk_summary_show(struct seq_file *s, void *data) > struct clk_core *c; > struct hlist_head **lists = (struct hlist_head **)s->private; > > - seq_puts(s, " clock enable_cnt prepare_cnt rate accuracy phase\n"); > - seq_puts(s, "----------------------------------------------------------------------------------------\n"); > + seq_puts(s, " clock enable_cnt prepare_cnt rate req_rate accuracy phase\n"); > + seq_puts(s, "----------------------------------------------------------------------------------------------------------------------\n"); > > clk_prepare_lock(); > > @@ -2070,6 +2070,7 @@ static void clk_dump_one(struct seq_file *s, struct clk_core *c, int level) > seq_printf(s, "\"enable_count\": %d,", c->enable_count); > seq_printf(s, "\"prepare_count\": %d,", c->prepare_count); > seq_printf(s, "\"rate\": %lu,", clk_core_get_rate(c)); > + seq_printf(s, "\"req_rate\": %lu,", c->req_rate); > seq_printf(s, "\"accuracy\": %lu,", clk_core_get_accuracy(c)); > seq_printf(s, "\"phase\": %d", clk_core_get_phase(c)); > } > -- > 1.9.1 >