Subject: Re: [PATCH v5 04/12] drm: bridge: analogix: Destroy connector &
 encoder when unbinding
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>, Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        briannorris@chromium.org, dianders@chromium.org,
        dri-devel@lists.freedesktop.org, tfiga@chromium.org,
        zyw@rock-chips.com, Yakir Yang <kuankuan.y@gmail.com>
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <59da511f-5243-fffb-f366-a51807b04a20@samsung.com>
Date: Fri, 07 Apr 2017 14:01:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.8.0
MIME-version: 1.0
In-reply-to: <1491481885-13775-5-git-send-email-jeffy.chen@rock-chips.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
CMS-TYPE: 201P
References: <1491481885-13775-1-git-send-email-jeffy.chen@rock-chips.com>
 <CGME20170406232740epcas2p41dd575b4e156a3d69bc6056e5a54c106@epcas2p4.samsung.com>
 <1491481885-13775-5-git-send-email-jeffy.chen@rock-chips.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1744
Lines: 49

On 06.04.2017 14:31, Jeffy Chen wrote:
> Normally we do this in drm_mode_config_cleanup. But:
> 1/ analogix dp's connector is allocated in bind, and freed after unbind.
> So we need to destroy it in unbind to avoid further access.
> 2/ the drm bridge is attached in bind, and detached in encoder cleanup.
> So we need to destroy encoder in unbind.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

In general drm core should free drm resources, doing it in component can
hurt some day. Maybe it would be good to move some stuff from
bind/unbind to probe/remove if necessary, to allow connector and encoder
to live little bit longer, and be destroyed by drm core. This is just
suggestion, I am not familiar enough with the driver to make stronger
statements :)

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

 --
Regards
Andrzej


> ---
>
> Changes in v5: None
> Changes in v4:
> Address Andrzej Hajda <a.hajda@samsung.com>'s comments.
>
> Changes in v3: None
> Changes in v2: None
>
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index d05ade4..4c758ed 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1439,6 +1439,8 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
>  	struct analogix_dp_device *dp = dev_get_drvdata(dev);
>  
>  	analogix_dp_bridge_disable(dp->bridge);
> +	dp->connector.funcs->destroy(&dp->connector);
> +	dp->encoder->funcs->destroy(dp->encoder);
>  
>  	if (dp->plat_data->panel) {
>  		if (drm_panel_unprepare(dp->plat_data->panel))