Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755894AbdDGMu7 (ORCPT ); Fri, 7 Apr 2017 08:50:59 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33066 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbdDGMut (ORCPT ); Fri, 7 Apr 2017 08:50:49 -0400 Date: Fri, 7 Apr 2017 14:50:44 +0200 From: Corentin Labbe To: Maxime Ripard Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 04/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner syscon Message-ID: <20170407125044.GB15546@Red> References: <20170403091444.29876-1-clabbe.montjoie@gmail.com> <20170403091444.29876-5-clabbe.montjoie@gmail.com> <20170403111954.tolvlw7klswaxkl4@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170403111954.tolvlw7klswaxkl4@lukather> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1595 Lines: 41 On Mon, Apr 03, 2017 at 01:19:54PM +0200, Maxime Ripard wrote: > On Mon, Apr 03, 2017 at 11:14:28AM +0200, Corentin Labbe wrote: > > Signed-off-by: Corentin Labbe > > --- > > .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > > > diff --git a/Documentation/devicetree/bindings/misc/allwinner,syscon.txt b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > new file mode 100644 > > index 0000000..9f5f1f5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > @@ -0,0 +1,19 @@ > > +* Allwinner sun8i system controller > > + > > +This file describes the bindings for the system controller present in > > +Allwinner SoC H3, A83T and A64. > > +The principal function of this syscon is to control EMAC PHY choice and > > +config. > > + > > +Required properties for the system controller: > > +- reg: address and length of the register for the device. > > +- compatible: should be "syscon" and one of the following string: > > + "allwinner,sun8i-h3-system-controller" > > + "allwinner,sun8i-a64-system-controller" > > + "allwinner,sun8i-a83t-system-controller" > > + > > +Example: > > +syscon: syscon@01c00000 { > > + compatible = "syscon", "allwinner,sun8i-h3-system-controller"; > > The syntax is the more specific first, so your compatibles should be > the other way around. > Changed it everywhere, and forgot to do it here I will change it Thanks Regards