Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756049AbdDGNTj (ORCPT ); Fri, 7 Apr 2017 09:19:39 -0400 Received: from mail.kernel.org ([198.145.29.136]:54622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755455AbdDGNTd (ORCPT ); Fri, 7 Apr 2017 09:19:33 -0400 Date: Fri, 7 Apr 2017 21:19:15 +0800 From: Shawn Guo To: Jagan Teki Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sascha Hauer , Fabio Estevam , Matteo Lisi , Michael Trimarchi , Jagan Teki Subject: Re: [PATCH v3 2/9] ARM: dts: imx6ul-geam: Add Sound card with codec node Message-ID: <20170407131914.GI16503@dragon> References: <1491501735-1649-1-git-send-email-jagan@openedev.com> <1491501735-1649-3-git-send-email-jagan@openedev.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491501735-1649-3-git-send-email-jagan@openedev.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2660 Lines: 91 On Thu, Apr 06, 2017 at 11:32:08PM +0530, Jagan Teki wrote: > From: Jagan Teki > > Add support for Sound card and related codec(via i2c1) nodes > on Engicam GEAM6UL variant module boards. > > Cc: Shawn Guo > Cc: Matteo Lisi > Cc: Michael Trimarchi > Signed-off-by: Jagan Teki > --- > Changes for v3: > - Replace fsl,imx-audio-sgtl5000 and use simple-audio-card > Changes for v2: > - Use proper [label:] node-name[@unit-address] for codec > - Remove incorrect codec property 'wlf,shared-lrclk' > - Remove 'gpr' from sound card node > > arch/arm/boot/dts/imx6ul-geam-kit.dts | 12 ++++++++++++ > arch/arm/boot/dts/imx6ul-geam.dtsi | 26 ++++++++++++++++++++++++++ Same question here: why is sgtl5000 added to imx6ul-geam-kit.dts, while sound code that references to sgtl5000 is added to imx6ul-geam.dtsi? Shawn > 2 files changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul-geam-kit.dts b/arch/arm/boot/dts/imx6ul-geam-kit.dts > index 142e60c..02edcba 100644 > --- a/arch/arm/boot/dts/imx6ul-geam-kit.dts > +++ b/arch/arm/boot/dts/imx6ul-geam-kit.dts > @@ -58,6 +58,18 @@ > status = "okay"; > }; > > +&i2c1 { > + sgtl5000: codec@a { > + compatible = "fsl,sgtl5000"; > + reg = <0x0a>; > + clocks = <&clks IMX6UL_CLK_OSC>; > + clock-names = "mclk"; > + VDDA-supply = <®_3p3v>; > + VDDIO-supply = <®_3p3v>; > + VDDD-supply = <®_1p8v>; > + }; > +}; > + > &lcdif { > display = <&display0>; > status = "okay"; > diff --git a/arch/arm/boot/dts/imx6ul-geam.dtsi b/arch/arm/boot/dts/imx6ul-geam.dtsi > index eb94d95..3bc3238 100644 > --- a/arch/arm/boot/dts/imx6ul-geam.dtsi > +++ b/arch/arm/boot/dts/imx6ul-geam.dtsi > @@ -87,6 +87,32 @@ > regulator-always-on; > regulator-boot-on; > }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "imx6ul-geam-sgtl5000"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,bitclock-master = <&dailink_master>; > + simple-audio-card,frame-master = <&dailink_master>; > + simple-audio-card,widgets = > + "Microphone", "Mic Jack", > + "Line", "Line In", > + "Line", "Line Out", > + "Headphone", "Headphone Jack"; > + simple-audio-card,routing = > + "MIC_IN", "Mic Jack", > + "Mic Jack", "Mic Bias", > + "Headphone Jack", "HP_OUT"; > + > + simple-audio-card,cpu { > + sound-dai = <&sai2>; > + }; > + > + dailink_master: simple-audio-card,codec { > + sound-dai = <&sgtl5000>; > + clocks = <&clks IMX6UL_CLK_SAI2>; > + }; > + }; > }; > > &can1 { > -- > 1.9.1 >