Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756678AbdDGOcc (ORCPT ); Fri, 7 Apr 2017 10:32:32 -0400 Received: from 8bytes.org ([81.169.241.247]:48921 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756579AbdDGOcX (ORCPT ); Fri, 7 Apr 2017 10:32:23 -0400 From: Joerg Roedel To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Drake , Alexander Deucher , Samuel Sieb , David Woodhouse , Joerg Roedel Subject: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Date: Fri, 7 Apr 2017 16:32:18 +0200 Message-Id: <1491575538-22694-1-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1439 Lines: 45 From: Joerg Roedel ATS is broken on this hardware and causes IOMMU stalls and system failure. Disable ATS on these devices to make them usable again with IOMMU enabled. Note that the commit in the Fixes-tag is not buggy, it just uncovers the problem in the hardware by increasing the ATS-flush rate. Fixes: b1516a14657a ('iommu/amd: Implement flush queue') Signed-off-by: Joerg Roedel --- drivers/pci/quirks.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 6736836..7cbe316 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4634,3 +4634,22 @@ static void quirk_no_aersid(struct pci_dev *pdev) DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2031, quirk_no_aersid); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2032, quirk_no_aersid); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2033, quirk_no_aersid); + +#ifdef CONFIG_PCI_ATS +/* + * Some devices have a broken ATS implementation causing IOMMU stalls. + * Don't use ATS for those devices. + */ +static void quirk_disable_ats(struct pci_dev *pdev) +{ + /* + * Set pdev->ats_cap = 0 to make pci_enable_ats() bail out + * early. + */ + dev_info(&pdev->dev, "QUIRK: Disabling ATS"); + pdev->ats_cap = 0; +} + +/* AMD Stoney platform GPU */ +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x98e4, quirk_disable_ats); +#endif /* CONFIG_PCI_ATS */ -- 1.9.1