Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934208AbdDGPFH (ORCPT ); Fri, 7 Apr 2017 11:05:07 -0400 Received: from mail.kernel.org ([198.145.29.136]:46874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933979AbdDGPFA (ORCPT ); Fri, 7 Apr 2017 11:05:00 -0400 Date: Fri, 7 Apr 2017 12:04:53 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan , Masami Hiramatsu Subject: Re: [PATCH 1/5] perf annotate: Refactor the code to parse disassemble lines with {l,r}trim() Message-ID: <20170407150453.GE2966@kernel.org> References: <1491575061-704-1-git-send-email-treeze.taeung@gmail.com> <1491575061-704-2-git-send-email-treeze.taeung@gmail.com> <20170407150130.GC2966@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407150130.GC2966@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 24 Em Fri, Apr 07, 2017 at 12:01:30PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Apr 07, 2017 at 11:24:17PM +0900, Taeung Song escreveu: > > @@ -1148,9 +1136,9 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map, > > { > > struct annotation *notes = symbol__annotation(sym); > > struct disasm_line *dl; > > - char *line = NULL, *parsed_line, *tmp, *tmp2, *c; > > + char *line = NULL, *parsed_line, *tmp, *tmp2; > > size_t line_len; > > - s64 line_ip, offset = -1; > > + s64 line_ip = -1, offset = -1; > > Try to avoid doing these unrelated changes, i.e. moving the setting of > line_ip to -1 from down below to here. > > It is unrelated to what you're doing here, i.e. using ltrim/rtrim, and > requires looking at the code to see if this can be done, as I don't know > if line_ip is set to something else in-between... I am removing this, > leaving the patch just for rtrim/ltrim. Ok, please do it yourself, after taking into account the other comment on this patch, I'm looking at the other patches now. - Arnaldo