Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933930AbdDGPqT (ORCPT ); Fri, 7 Apr 2017 11:46:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52578 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755541AbdDGPqN (ORCPT ); Fri, 7 Apr 2017 11:46:13 -0400 Date: Fri, 7 Apr 2017 17:46:02 +0200 From: Greg Kroah-Hartman To: Varsha Rao Cc: Matthew Wilcox , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] drivers: char: Replace printk with pr_err. Message-ID: <20170407154602.GB11575@kroah.com> References: <58e77939.cca3620a.762de.3de9@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58e77939.cca3620a.762de.3de9@mx.google.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 24 On Fri, Apr 07, 2017 at 05:04:06PM +0530, Varsha Rao wrote: > Replace printk with pr_err to fix the checkpatch issue. > > Signed-off-by: Varsha Rao > --- > drivers/char/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/misc.c b/drivers/char/misc.c > index 1312e29..c9cd1ea 100644 > --- a/drivers/char/misc.c > +++ b/drivers/char/misc.c > @@ -294,7 +294,7 @@ static int __init misc_init(void) > return 0; > > fail_printk: > - printk("unable to get major %d for misc devices\n", MISC_MAJOR); > + pr_err("unable to get major %d for misc devices\n", MISC_MAJOR); Is pr_fmt properly set to use this? thanks, greg k-h