Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934177AbdDGQL4 (ORCPT ); Fri, 7 Apr 2017 12:11:56 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:5381 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148AbdDGQLs (ORCPT ); Fri, 7 Apr 2017 12:11:48 -0400 X-IronPort-AV: E=Sophos;i="5.37,166,1488870000"; d="scan'208";a="1135975" From: To: , , , , , CC: , , , Cristian Birsan Subject: [PATCH v4 1/2] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error Date: Fri, 7 Apr 2017 19:07:21 +0300 Message-ID: <08d921b687965dc77ce48b5da30ebabacbc60590.1491577793.git.cristian.birsan@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 38 From: Cristian Birsan Use dev_err() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 8bc0b52a..3ccc341 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -1851,8 +1851,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) * but it's clearly harmless... */ if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, - "ODD: EP0 configuration is invalid!\n"); + dev_err(&udc->pdev->dev, + "ODD: EP0 configuration is invalid!\n"); /* Preallocate other endpoints */ n = fifo_mode ? udc->num_ep : udc->configured_ep; @@ -1860,8 +1860,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) ep = &udc->usba_ep[i]; usba_ep_writel(ep, CFG, ep->ept_cfg); if (!(usba_ep_readl(ep, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, - "ODD: EP%d configuration is invalid!\n", i); + dev_err(&udc->pdev->dev, + "ODD: EP%d configuration is invalid!\n", i); } } -- 2.7.4