Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934388AbdDGQs0 (ORCPT ); Fri, 7 Apr 2017 12:48:26 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:35480 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbdDGQsU (ORCPT ); Fri, 7 Apr 2017 12:48:20 -0400 Subject: Re: [PATCH net-next] bindings: net: stmmac: add missing note about LPI interrupt To: Niklas Cassel , Rob Herring , Mark Rutland , "David S. Miller" , Joao Pinto , Alexandre TORGUE , Niklas Cassel , Giuseppe CAVALLARO , Thierry Reding , Eric Engestrom References: <20170407143100.21536-1-niklass@axis.com> Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Fri, 7 Apr 2017 19:48:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170407143100.21536-1-niklass@axis.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 36 Hello! On 04/07/2017 05:30 PM, Niklas Cassel wrote: > From: Niklas Cassel > > The hardware has a LPI interrupt. > There is already code in the stmmac driver to parse and handle the > interrupt. However, this information was missing from the DT binding. > > Signed-off-by: Niklas Cassel > --- > Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index f652b0c384ce..8977abc266ac 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -8,8 +8,8 @@ Required properties: > that services interrupts for this device > - interrupts: Should contain the STMMAC interrupts > - interrupt-names: Should contain the interrupt names "macirq" > - "eth_wake_irq" if this interrupt is supported in the "interrupts" > - property > + "eth_wake_irq" if this interrupt is supported in the "interrupts property Missed closing quote? > + "eth_lpi" if this interrupt is supported in the "interrupts" property > - phy-mode: See ethernet.txt file in the same directory. > - snps,reset-gpio gpio number for phy reset. > - snps,reset-active-low boolean flag to indicate if phy reset is active low. [...] MBR, Sergei