Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934449AbdDGQ6m (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Apr 2017 12:58:42 -0400
Received: from mail-pg0-f42.google.com ([74.125.83.42]:33470 "EHLO
        mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934426AbdDGQ62 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Apr 2017 12:58:28 -0400
Date: Fri, 7 Apr 2017 09:58:17 -0700 (PDT)
From: Hugh Dickins <hughd@google.com>
X-X-Sender: hugh@eggly.anvils
To: Michal Hocko <mhocko@kernel.org>
cc: Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@techsingularity.net>, Tejun Heo <tj@kernel.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Is it safe for kthreadd to drain_all_pages?
In-Reply-To: <20170407163932.GJ16413@dhcp22.suse.cz>
Message-ID: <alpine.LSU.2.11.1704070952530.2261@eggly.anvils>
References: <alpine.LSU.2.11.1704051331420.4288@eggly.anvils> <20170406130614.a6ygueggpwseqysd@techsingularity.net> <alpine.LSU.2.11.1704061134240.17094@eggly.anvils> <alpine.LSU.2.11.1704070914520.1566@eggly.anvils> <20170407163932.GJ16413@dhcp22.suse.cz>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1164
Lines: 26

On Fri, 7 Apr 2017, Michal Hocko wrote:
> On Fri 07-04-17 09:25:33, Hugh Dickins wrote:
> [...]
> > 24 hours so far, and with a clean /var/log/messages.  Not conclusive
> > yet, and of course I'll leave it running another couple of days, but
> > I'm increasingly sure that it works as you intended: I agree that
> > 
> > mm-move-pcp-and-lru-pcp-drainging-into-single-wq.patch
> > mm-move-pcp-and-lru-pcp-drainging-into-single-wq-fix.patch
> > 
> > should go to Linus as soon as convenient.  Though I think the commit
> > message needs something a bit stronger than "Quite annoying though".
> > Maybe add a line:
> > 
> > Fixes serious hang under load, observed repeatedly on 4.11-rc.
> 
> Yeah, it is much less theoretical now. I will rephrase and ask Andrew to
> update the chagelog and send it to Linus once I've got your final go.

I don't know akpm's timetable, but your fix being more than a two-liner,
I think it would be better if it could get into rc6, than wait another
week for rc7, just in case others then find problems with it.  So I
think it's safer *not* to wait for my final go, but proceed on the
assumption that it will follow a day later.

Hugh