Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934508AbdDGTp0 (ORCPT ); Fri, 7 Apr 2017 15:45:26 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33114 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933753AbdDGTpL (ORCPT ); Fri, 7 Apr 2017 15:45:11 -0400 Subject: Re: [PATCH net-next v4 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch To: sean.wang@mediatek.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com References: <1491554709-9723-1-git-send-email-sean.wang@mediatek.com> <1491554709-9723-6-git-send-email-sean.wang@mediatek.com> Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, davem@davemloft.net, Landen.Chao@mediatek.com, keyhaede@gmail.com, objelf@gmail.com From: Florian Fainelli Message-ID: <030c4e95-e604-9864-fce3-9d52561e9a95@gmail.com> Date: Fri, 7 Apr 2017 12:45:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491554709-9723-6-git-send-email-sean.wang@mediatek.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 31 On 04/07/2017 01:45 AM, sean.wang@mediatek.com wrote: > From: Sean Wang > > MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on > Mediatek router platforms such as MT7623A or MT7623N platform which > includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. > Among these ports, The port from 0 to 4 are the user ports connecting > with the remote devices while the port 5 and 6 are the CPU ports > connecting into Mediatek Ethernet GMAC. > > For port 6, it can communicate with the CPU via Mediatek Ethernet GMAC > through either the TRGMII or RGMII which could be controlled by phy-mode > in the dt-bindings to specify which mode is preferred to use. And for > port 5, only RGMII can be specified. However, currently, only port 6 is > being supported in this DSA driver. > > The driver is made with the reference to qca8k and other existing DSA > driver. The most of the essential callbacks of the DSA are already > support in the driver, including tag insert for user port distinguishing, > port control, bridge offloading, STP setup and ethtool operation to allow > DSA to model each user port into a standalone netdevice as the other DSA > driver had done. > > Signed-off-by: Sean Wang > Signed-off-by: Landen Chao Reviewed-by: Florian Fainelli -- Florian