Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbdDHD23 (ORCPT ); Fri, 7 Apr 2017 23:28:29 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33795 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbdDHD2V (ORCPT ); Fri, 7 Apr 2017 23:28:21 -0400 Subject: Re: [PATCH 11/24] uswsusp: Disable when the kernel is locked down To: Jiri Kosina , "Rafael J. Wysocki" Cc: David Howells , Oliver Neukum , Linux Kernel Mailing List , Matthew Garrett , linux-efi@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, Greg Kroah-Hartman , Linux PM , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Joey Lee , matthew.garrett@nebula.com References: <149142326734.5101.4596394505987813763.stgit@warthog.procyon.org.uk> <149142336965.5101.2946578135980499557.stgit@warthog.procyon.org.uk> <1491460792.1645.1.camel@suse.com> <14980.1491468060@warthog.procyon.org.uk> From: poma Message-ID: <83e2dff5-c46b-25b4-253e-cd2650b7db7d@gmail.com> Date: Sat, 8 Apr 2017 05:28:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 31 On 06.04.2017 22:25, Jiri Kosina wrote: > On Thu, 6 Apr 2017, Rafael J. Wysocki wrote: > >>>>> Your swap partition may be located on an NVDIMM or be encrypted. >>>> >>>> An NVDIMM should be considered the same as any other persistent storage. >>>> >>>> It may be encrypted, but where's the key stored, how easy is it to retrieve >>>> and does the swapout code know this? >>>> >>>>> Isn't this a bit overly drastic? >>>> >>>> Perhaps, but if it's on disk and it's not encrypted, then maybe not. >>> >>> Right. >>> >>> Swap encryption is not mandatory and I'm not sure how the hibernate >>> code can verify whether or not it is in use. >> >> BTW, SUSE has patches adding secure boot support to the hibernate code >> and Jiri promised me to post them last year even. :-) > > Oh, thanks for a friendly ping :) Adding Joey Lee to CC. > Rafael J., are you talking about HIBERNATE_VERIFICATION ? Ref. https://github.com/joeyli/linux-s4sign/commits/s4sign-hmac-v2-v4.2-rc8 https://lkml.org/lkml/2015/8/11/47 https://bugzilla.redhat.com/show_bug.cgi?id=1330335