Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264026AbTE3WgT (ORCPT ); Fri, 30 May 2003 18:36:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264023AbTE3WgT (ORCPT ); Fri, 30 May 2003 18:36:19 -0400 Received: from neon-gw-l3.transmeta.com ([63.209.4.196]:40202 "EHLO neon-gw.transmeta.com") by vger.kernel.org with ESMTP id S264060AbTE3WgS (ORCPT ); Fri, 30 May 2003 18:36:18 -0400 Date: Fri, 30 May 2003 15:49:12 -0700 (PDT) From: Linus Torvalds To: Davide Libenzi cc: =?iso-8859-1?Q?J=F6rn?= Engel , Linux Kernel Mailing List Subject: Re: [PATCH] 2.5 Documentation/CodingStyle ANSI C function declarations. In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 May 2003, Davide Libenzi wrote: > > Talking about the code, there are still a bunch of files that uses spaces > with tabsize=4. Shouldn't those be reformatted with real TABs ? An emacs > lisp (indent+tabify) might do it pretty fast ... I don't generally like changing syntactic stuff without a reason. A good reason is when the original maintainer is not that active any more, and a new maintainer (or even just random fixer) feels that they need to run indent on the sources in order to make them more readable before doign a fix. It happens, but not very often. Alan and Al both do it to the files they clean up. But I don't like having it done "just because" - there should be a real underlying reason. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/