Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751727AbdDHFBx (ORCPT <rfc822;w@1wt.eu>);
        Sat, 8 Apr 2017 01:01:53 -0400
Received: from mout.gmx.net ([212.227.15.19]:58117 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750986AbdDHFBp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 8 Apr 2017 01:01:45 -0400
Message-ID: <1491627694.4479.21.camel@gmx.de>
Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use
 shared interrupts for virtqueues")
From: Mike Galbraith <efault@gmx.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        virtio-dev@lists.oasis-open.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        rjones@redhat.com
Date: Sat, 08 Apr 2017 07:01:34 +0200
In-Reply-To: <20170407215510-mutt-send-email-mst@kernel.org>
References: <20170405062934.GA26528@lst.de>
         <20170406003349-mutt-send-email-mst@kernel.org>
         <1491544999.5501.7.camel@gmx.de>
         <20170407090354-mutt-send-email-mst@kernel.org>
         <1491547457.5501.10.camel@gmx.de> <1491548751.5501.12.camel@gmx.de>
         <1491549722.5501.13.camel@gmx.de>
         <20170407161641-mutt-send-email-mst@kernel.org>
         <20170407163437-mutt-send-email-mst@kernel.org>
         <1491575393.3341.0.camel@gmx.de>
         <20170407215510-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:tB4hxKIY1P30OOsdlRw8ogTg/UCcIV947ok5UQ+LA9UAvGNgfsf
 FyB9AhW3tPYj61L+Mf5TgPtMDRxuL2qPtxHBc+Cg0EzUsxF58FLnbLlij/LE1qLWoUhrCTN
 RINLyv7dyNM35yDlkg8IY+aMAlf+5Y+4xFyX58Bl8gaKyMQzwpojFYrzinPFb5Q8owrKHWa
 dGiUGEQ1wafG0WxhETkBg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ndvMgp13nco=:gN6o9rX0CnY5++Rjmfc0Fn
 WSo0eTyl7PYKLllFMzdo7VukAWxkjUWx7QWqE2Te3rtajIeFW8jccnZ0I9cqgrrE7KsWoUm3m
 JBKcZ1j7bvgJZT6j9FkXAJ6anBZYcMDXQ1N94e4ewqkI1JwwfxZ/FnssdtyqDjBP5lX83zP0g
 KrEpcYy7SIK04Cv0j21TDzp3LrhAcVfBg7iGgOEVnRP3947LnS3fz6yVhwTMkYBYJlOw31qbe
 q5VXkVTuup9m1YnAY3dVDzXV1K60P7Xa9rp/lBoSoMY/gPifinIt3VKL/tJsDRQKstdHDu4be
 IyJEZTJ5Frj8b0zrv418EBpj6DDCbCZ6+dU7bakgd17laWd7Du/IuRBG/2FRKkBEalru0tL4u
 Xwbqt+8oRGuww4MRHMSyF1vdKr208hMVlWvUaSZghesAF6GAZxaR9pN1nDIpU80PX2OZguTfM
 vGamLV/4lN7haMKtgCb815xo0d9zRHUVwxe5xX425Tqq1DtpCPH0H2oHJ+ss/7kdfQ6E1qMz6
 UmT09QTXLMfUYPh6tAU7LdttWUhPMwkGcK6lunfoAh+Y1g+X5WIlYERZ1jwKlyPPxWjf8a8nO
 LKdduZhUqrYnhD/NSOTcGdcmVhGChNYwGyN7fZDf+5Jzp8tfmgXqCHU+Ja1M6kTwHLnAwbgKr
 Q4czaHcm0tzexIlFiZf9ahyUzUJ0o1SfN9qRVgS8fo64hGdYPemlur8B3uYD8XfyvNJscmyk7
 7Za1vLGxWindU1hs9sbb2ofOErcI11U0IBHhxCVkKTXAkUSYlNhWsJ82fdeLseIffg3PM422+
 RBcYxMw
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1488
Lines: 32

On Fri, 2017-04-07 at 21:56 +0300, Michael S. Tsirkin wrote:

> OK. test3 and test4 are now pushed: test3 should fix your hang,
> test4 is trying to fix a crash reported independently.

test3 does not fix the post hibernate hang business that I can easily
reproduce, those are NFS, and at least as old as 4.4.  Host/guest,
dunno, put 4.4 on both, guest hangs intermittently.

[<ffffffffa039a550>] __rpc_wait_for_completion_task+0x30/0x30 [sunrpc]
[<ffffffffa039a56e>] rpc_wait_bit_killable+0x1e/0xb0 [sunrpc]
[<ffffffffa039a550>] __rpc_wait_for_completion_task+0x30/0x30 [sunrpc]
[<ffffffff810c6450>] autoremove_wake_function+0x50/0x50
[<ffffffffa038f670>] call_decode+0x850/0x850 [sunrpc]
[<ffffffffa038f670>] call_decode+0x850/0x850 [sunrpc]
[<ffffffffa039b17e>] __rpc_execute+0x14e/0x440 [sunrpc]
[<ffffffff810f7d35>] ktime_get+0x35/0xa0
[<ffffffffa0390900>] rpc_run_task+0x120/0x170 [sunrpc]
[<ffffffffa064a1c6>] nfs4_call_sync_sequence+0x56/0x80 [nfsv4]
[<ffffffffa064acd0>] _nfs4_proc_getattr+0xb0/0xc0 [nfsv4]
[<ffffffff8123f8b2>] path_lookupat+0xd2/0x100
[<ffffffffa0655d9c>] nfs4_proc_getattr+0x5c/0xe0 [nfsv4]
[<ffffffffa0612120>] __nfs_revalidate_inode+0xa0/0x300 [nfs]
[<ffffffffa0612485>] nfs_getattr+0x95/0x250 [nfs]
[<ffffffff812365eb>] vfs_statx+0x7b/0xc0
[<ffffffff81236a60>] SYSC_newstat+0x20/0x40
[<ffffffff81687177>] entry_SYSCALL_64_fastpath+0x1a/0xa9
[<ffffffffffffffff>] 0xffffffffffffffff

I noted no _other_ misbehavior in either kernel, w/wo threadirqs.

	-Mike