Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752678AbdDHPD7 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 8 Apr 2017 11:03:59 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:42826 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751624AbdDHPDu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 8 Apr 2017 11:03:50 -0400
Date: Sat, 8 Apr 2017 17:03:38 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: aviyae <aviyae42@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: goldfish: Add parenthesis around macros
 arguments
Message-ID: <20170408150338.GA16049@kroah.com>
References: <c8b09724-8ed0-4b89-699b-77fb3c27afd5@gmail.com>
 <159caafb-be9c-32d7-9a15-e8593e93ddca@gmail.com>
 <cd914524-d22e-faa4-44a4-c705b298a385@gmail.com>
 <2cf02d91-9ad5-164e-24fd-f76e86b277ec@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2cf02d91-9ad5-164e-24fd-f76e86b277ec@gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1354
Lines: 33

On Thu, Mar 30, 2017 at 12:11:05AM +0300, aviyae wrote:
> Fix style issues by adding parenthesis around macros
> arguments
> 
> Signed-off-by: Aviya Erenfeld <aviyae42@gmail.com>
> ---
>  drivers/staging/goldfish/goldfish_audio.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index bd55995..2bb1f27 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -61,10 +61,11 @@ struct goldfish_audio {
>  #define COMBINED_BUFFER_SIZE    ((2 * READ_BUFFER_SIZE) + \
>                                         (2 * WRITE_BUFFER_SIZE))
> 
> -#define AUDIO_READ(data, addr)         (readl(data->reg_base + addr))
> -#define AUDIO_WRITE(data, addr, x)     (writel(x, data->reg_base + addr))
> +#define AUDIO_READ(data, addr)         (readl((data)->reg_base + (addr)))
> +#define AUDIO_WRITE(data, addr, x)     (writel(x, (data)->reg_base + (addr)))
>  #define AUDIO_WRITE64(data, addr, addr2, x)    \
> -       (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))
> +       (gf_write_dma_addr((x), (data)->reg_base + (addr), \
> +       (data)->reg_base + (addr2)))

Your indentation here is odd, please fix up.

And is this really a needed change?

thanks,

greg k-h