Subject: Re: [PATCH v5 2/2] iio: Aspeed ADC
To: Stephen Boyd <sboyd@codeaurora.org>
References: <20170328215259.31622-1-raltherr@google.com>
 <20170328215259.31622-2-raltherr@google.com>
 <d05cadfe-e3d3-f4e8-129f-19dcd2f637da@kernel.org>
 <20170405215046.GE7065@codeaurora.org>
Cc: Rick Altherr <raltherr@google.com>, openbmc@lists.ozlabs.org,
        linux-kernel@vger.kernel.org,
        William Breathitt Gray <vilhelm.gray@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Andreas Klinger <ak@it-klinger.de>, Rob Herring <robh@kernel.org>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Quentin Schulz <quentin.schulz@free-electrons.com>,
        linux-iio@vger.kernel.org, Zhiyong Tao <zhiyong.tao@mediatek.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
        Scott Branden <scott.branden@broadcom.com>,
        Crestez Dan Leonard <leonard.crestez@intel.com>,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Fabrice Gasnier <fabrice.gasnier@st.com>,
        Hartmut Knaack <knaack.h@gmx.de>, linux-clk@vger.kernel.org
From: Jonathan Cameron <jic23@kernel.org>
Message-ID: <b1919652-4db7-0373-278b-483357968e7e@kernel.org>
Date: Sat, 8 Apr 2017 17:15:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170405215046.GE7065@codeaurora.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1362
Lines: 32

On 05/04/17 22:50, Stephen Boyd wrote:
> On 04/01, Jonathan Cameron wrote:
>> On 28/03/17 22:52, Rick Altherr wrote:
>>> Aspeed BMC SoCs include a 16 channel, 10-bit ADC. Low and high threshold
>>> interrupts are supported by the hardware but are not currently implemented.
>>>
>>> Signed-off-by: Rick Altherr <raltherr@google.com>
>> Two really trivial things inline. I'll fix them whilst applying rather than
>> having you do a v6 - please do sanity check I haven't messed it up though!
>>
>> Applied to the togreg branch of iio.git and pushed out as testing for
>> the autobuilders to play with it.
>>
> 
> Oh I was too late. Blame work. Anyway, I made some comments on
> v4. If they're fixed in a later patch or discussed on list that's
> fine. No worries on my end.
> 
Oops. I went a bit quick on this one I guess.

Anyhow, from a quick read of your comments I'm not sure if any of
them are such that we should revert.  Perhaps we Rick can prepare
a follow up patch covering them?  I got a little lost so am not
sure but if there is anything effecting bindings Rick, please
get this through asap or let me know if we need to revert for now.
Even if it is a case of adding a bit of binding and following up
with the code using it a bit later.

I'd asked for input on the clock stuff then forgot all about it on
the later version. Sorry about that!

Jonathan