Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbdDHSWH (ORCPT ); Sat, 8 Apr 2017 14:22:07 -0400 Received: from a3.inai.de ([88.198.180.161]:59994 "EHLO a3.inai.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbdDHSV7 (ORCPT ); Sat, 8 Apr 2017 14:21:59 -0400 Date: Sat, 8 Apr 2017 20:21:56 +0200 (CEST) From: Jan Engelhardt To: Arushi Singhal cc: pablo@netfilter.org, Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: netfilter: Replace explicit NULL comparisons In-Reply-To: <20170408172113.GA9352@arushi-HP-Pavilion-Notebook> Message-ID: References: <20170408172113.GA9352@arushi-HP-Pavilion-Notebook> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 290 Lines: 7 On Saturday 2017-04-08 19:21, Arushi Singhal wrote: >Replace explicit NULL comparison with ! operator to simplify code. I still wouldn't do this, for the same reason as before. Comparing to NULL explicitly more or less gave an extra guarantee that the other operand was also a pointer.