Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbdDHUPA (ORCPT ); Sat, 8 Apr 2017 16:15:00 -0400 Received: from mail.us.es ([193.147.175.20]:53564 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbdDHUOo (ORCPT ); Sat, 8 Apr 2017 16:14:44 -0400 Date: Sat, 8 Apr 2017 22:14:38 +0200 From: Pablo Neira Ayuso To: Jan Engelhardt Cc: Arushi Singhal , Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: netfilter: Replace explicit NULL comparisons Message-ID: <20170408201438.GC2679@salvia> References: <20170408172113.GA9352@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 438 Lines: 10 On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote: > On Saturday 2017-04-08 19:21, Arushi Singhal wrote: > > >Replace explicit NULL comparison with ! operator to simplify code. > > I still wouldn't do this, for the same reason as before. Comparing to > NULL explicitly more or less gave an extra guarantee that the other > operand was also a pointer. Arushi, where does it say in the coding style that this is prefered?