Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbdDIVFT (ORCPT ); Sun, 9 Apr 2017 17:05:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52993 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752717AbdDIVFR (ORCPT ); Sun, 9 Apr 2017 17:05:17 -0400 Subject: Re: [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master To: Randy Dunlap , robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, rostedt@goodmis.org, mingo@redhat.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20170405020607.79939-1-cbostic@linux.vnet.ibm.com> <20170405020607.79939-20-cbostic@linux.vnet.ibm.com> <5d173f9c-e01c-6093-16ab-d114857009b2@infradead.org> Cc: joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au, alistair@popple.id.au, benh@kernel.crashing.org, "Edward A . James" , Jeremy Kerr From: Christopher Bostic Date: Sun, 9 Apr 2017 16:04:59 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <5d173f9c-e01c-6093-16ab-d114857009b2@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17040921-0024-0000-0000-0000023EB19B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006907; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00845243; UDB=6.00416785; IPR=6.00623669; BA=6.00005276; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014980; XFM=3.00000013; UTC=2017-04-09 21:05:15 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040921-0025-0000-0000-0000433B5D29 Message-Id: <518e0abc-f1da-2ca0-fa44-6802e2b74c71@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-09_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704090190 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1572 Lines: 50 On 4/5/17 11:35 AM, Randy Dunlap wrote: > On 04/04/17 19:06, Christopher Bostic wrote: >> From: Chris Bostic >> >> Implement a FSI master using GPIO. Will generate FSI protocol for >> read and write commands to particular addresses. Sends master command >> and waits for and decodes a slave response. >> >> Includes changes from Edward A. James and Jeremy >> Kerr . >> >> Signed-off-by: Edward A. James >> Signed-off-by: Jeremy Kerr >> Signed-off-by: Chris Bostic >> Signed-off-by: Joel Stanley >> --- >> drivers/fsi/Kconfig | 11 + >> drivers/fsi/Makefile | 1 + >> drivers/fsi/fsi-master-gpio.c | 610 ++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 622 insertions(+) >> create mode 100644 drivers/fsi/fsi-master-gpio.c >> >> diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig >> index 04c1a0e..9cf8345 100644 >> --- a/drivers/fsi/Kconfig >> +++ b/drivers/fsi/Kconfig >> @@ -9,4 +9,15 @@ config FSI >> ---help--- >> FSI - the FRU Support Interface - is a simple bus for low-level >> access to POWER-based hardware. >> + >> +if FSI >> + >> +config FSI_MASTER_GPIO >> + tristate "GPIO-based FSI master" >> + depends on FSI && GPIOLIB > depends on FSI is redundant since "if FSI" does the same thing. Hi Randy, Thanks for the feedback, will correct. -Chris >> + ---help--- >> + This option enables a FSI master driver using GPIO lines. >> + >> +endif >> + >